Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csv course data bundling #6

Merged
merged 4 commits into from
May 27, 2024
Merged

Fix csv course data bundling #6

merged 4 commits into from
May 27, 2024

Conversation

drewvolz
Copy link
Member

@drewvolz drewvolz commented Sep 5, 2018

Should let us close StoDevX/course-data#5

@drewvolz
Copy link
Member Author

drewvolz commented Sep 5, 2018

Build error:

"TypeError: sequence item 0: expected str instance, dict found" in course-data-tools/lib/csvify.py, line 15, in csvify

if type(item[key]) is list:
item[key] = ';'.join(item[key])

# update bundled information for public consumption
python3 ../bundle.py --out-dir ../course-data --format json --format xml --format csv
concurrent.futures.process._RemoteTraceback: 
"""
TypeError: sequence item 0: expected str instance, dict found

@hawkrives
Copy link
Member

Yes, there is a bug in the build process, which is why the CSV output was disabled.

@drewvolz
Copy link
Member Author

drewvolz commented Sep 5, 2018

Ah, you disabled that here.

@drewvolz
Copy link
Member Author

@hawkrives do you want to dig into this?

drewvolz added a commit that referenced this pull request Jun 3, 2023
@drewvolz drewvolz changed the title Create csv course data from travis Fix csv course data bundling May 27, 2024
@drewvolz drewvolz requested review from hawkrives and removed request for hawkrives May 27, 2024 08:58
@drewvolz
Copy link
Member Author

CSV output is now fixed. Converted each element to a string first to fix the export.

@drewvolz drewvolz merged commit 327ea49 into master May 27, 2024
1 check passed
@drewvolz drewvolz deleted the travis-csv branch May 27, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants