EventEmitter Memory leak fixed. #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible EventEmitter memory leak detected. over 26 data listeners are added therefore we can use the MaxListeners to increase the limit.
Possible EventEmitter memory leak detected. 27 data listeners are added therefore we can adjust the defaultMaxListeners to increase the limit.
Possible EventEmitter memory leak detected. 27 data listeners are added therefore we can adjust defaultMaxListeners to increase the limit.
MaxListenerExceededWarning fixed!
Possible EventEmitter memory leak detected. 21 data listeners are added therefore we can adjust defaultMaxListeners to increase the limit.
Possible EventEmitter memory leak detected. 15 data listeners are added therefore we can use the emitter.setMaxListener() to increase the limit.
dawsbot
suggested changes
Jan 29, 2019
| require('events').EventEmitter.defaultMaxListeners = 27; | ||
|
|
||
| ///MaxListenerExceededWarning fixed! | ||
| require('events').EventEmitter.defaultMaxListeners = 27; |
There was a problem hiding this comment.
Why is this defaultMaxListeners changed twice in this file?
|
Seems like a worthwhile PR, I didn't like getting these console warnings during my time following the Udemy lessons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A comment from your student on Udemy.