New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowercase org name when constructing docker tag names #323
Conversation
JFYI, builds are failing in CI until #322 is merged. |
85bc940
to
4805d00
Compare
Rebased on top of fix in #322 |
This resolves errors like: Error: buildx failed with: ERROR: invalid tag "ghcr.io/Stephane-D/sgdk-m68k-gcc:latest": repository name must be lowercase For example, see https://github.com/Stephane-D/SGDK/actions/runs/8545289521/job/23413232803
4805d00
to
6727215
Compare
On a PR, the actor is the contributor, but we need to know that we can build for the target repo.
I deleted the GCC image from my own account and created a PR to myself to prove that the bootstrapping steps work. The defaults set by Docker's official GitHub Action don't match the defaults you have locally when running the same build commands. This took a while to figure out. I also changed it to build using the org name of the repo the PR targets, so this workflow run will show you that it should work for you on push as well. Any push or PR merge will publish a new official package to GHCR. |
All workflows passing. Ready to merge when you are. Thanks! |
@Stephane-D, I see you have approved, but not yet merged. Can you please merge this? I'm ready to start referring to official SGDK builds in my projects instead of my forked version of SGDK, but because of this case-sensitivity issue, official Docker builds aren't being published from your repo yet. Thanks! |
This resolves errors like:
Error: buildx failed with: ERROR: invalid tag "ghcr.io/Stephane-D/sgdk-m68k-gcc:latest": repository name must be lowercase
For example, see https://github.com/Stephane-D/SGDK/actions/runs/8545289521/job/23413232803
This also fixes several additional workflow issues that occurred during debugging and development: