Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase org name when constructing docker tag names #323

Merged
merged 7 commits into from May 21, 2024

Conversation

joeyparrish
Copy link
Contributor

@joeyparrish joeyparrish commented Apr 4, 2024

This resolves errors like:

Error: buildx failed with: ERROR: invalid tag "ghcr.io/Stephane-D/sgdk-m68k-gcc:latest": repository name must be lowercase

For example, see https://github.com/Stephane-D/SGDK/actions/runs/8545289521/job/23413232803

This also fixes several additional workflow issues that occurred during debugging and development:

  • Build logs from crosstool-ng were overwhelming (180k+ useless lines of a progress bar), now disabled with CT_LOG_PROGRESS_BAR=n
  • Bootstrapping for first GCC image on main repo or fork was broken, now fixed to ensure workflow's GCC image used in later SGDK image.

@joeyparrish
Copy link
Contributor Author

JFYI, builds are failing in CI until #322 is merged.

@joeyparrish
Copy link
Contributor Author

Rebased on top of fix in #322

This resolves errors like:

Error: buildx failed with: ERROR: invalid tag "ghcr.io/Stephane-D/sgdk-m68k-gcc:latest": repository name must be lowercase

For example, see https://github.com/Stephane-D/SGDK/actions/runs/8545289521/job/23413232803
@joeyparrish joeyparrish changed the title Lowercase actor name when constructing docker tag names Lowercase org name when constructing docker tag names Apr 12, 2024
@joeyparrish joeyparrish marked this pull request as ready for review April 13, 2024 15:23
@joeyparrish
Copy link
Contributor Author

I deleted the GCC image from my own account and created a PR to myself to prove that the bootstrapping steps work. The defaults set by Docker's official GitHub Action don't match the defaults you have locally when running the same build commands. This took a while to figure out.

I also changed it to build using the org name of the repo the PR targets, so this workflow run will show you that it should work for you on push as well. Any push or PR merge will publish a new official package to GHCR.

@joeyparrish
Copy link
Contributor Author

All workflows passing. Ready to merge when you are. Thanks!

@joeyparrish
Copy link
Contributor Author

@Stephane-D, I see you have approved, but not yet merged. Can you please merge this?

I'm ready to start referring to official SGDK builds in my projects instead of my forked version of SGDK, but because of this case-sensitivity issue, official Docker builds aren't being published from your repo yet.

Thanks!

@Stephane-D Stephane-D merged commit d769c72 into Stephane-D:master May 21, 2024
2 of 3 checks passed
@joeyparrish joeyparrish deleted the fix-ghcr-case branch May 22, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants