This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
fix: do not delete inbound edi file when source is core artifact bucket #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using Core's remote sftp poller, the poller adds the document to Core's artifact bucket and sets this as the input when sending transaction processed events. In these cases the edi-inbound function should not attempt to delete the input since Core handles the work and the input is read-only. Fix tests which use the artifact bucket as the source input by default.
BDQ
approved these changes
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using Core's remote sftp poller, the poller adds the document to Core's artifact bucket and sets this as the input when sending transaction processed events. In these cases the edi-inbound function should not attempt to delete the input since Core handles the work and the input is read-only.
Fix tests which use the artifact bucket as the source input by default.