Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watch-mode): allow run plugin in watch mode #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IvanRodriCalleja
Copy link

@IvanRodriCalleja IvanRodriCalleja commented Jan 18, 2023

Fixes: #6

The problem with the watch mode was that the input for content script was not regenerated and the new manifest was wrong generated because the content script was not found in the bundle as a file.

@StarkShang Would you be open to review and release a new version in case you are agree with the fix or do you prefer that i fork the repo and maintain my own plugin?

@salmin89
Copy link

I would love to get this merged. @IvanRodriCalleja did this work for your local env? got a sandbox project setup for testing that I can tryout?

I tried in my own with npm install github:IvanRodriCalleja/vite-plugin-chrome-extension#0dc5405 but didn't get it to work

@IvanRodriCalleja
Copy link
Author

I had it working in my local with this changes but finally i migrated to @crxjs/vite-plugin

@salmin89
Copy link

@IvanRodriCalleja good idea, I will do that to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty build being generated when running vite build --watch
2 participants