Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ResearchKit #72

Merged
merged 5 commits into from
Feb 24, 2024
Merged

Upgrade ResearchKit #72

merged 5 commits into from
Feb 24, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Feb 23, 2024

Upgrade ResearchKit

♻️ Current situation & Problem

This bumps the minimum supported iOS version as ResearchKit was raised to iOS 15.

⚙️ Release Notes

  • New target iOS version.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg! 🚀

@Supereg Supereg changed the title Bump target version Upgrade ResearchKit Feb 24, 2024
@Supereg Supereg marked this pull request as ready for review February 24, 2024 00:23
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.61%. Comparing base (ea4d969) to head (c68abd3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   89.76%   83.61%   -6.14%     
==========================================
  Files           9        9              
  Lines         732      732              
==========================================
- Hits          657      612      -45     
- Misses         75      120      +45     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4d969...c68abd3. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 7f65fe3 into main Feb 24, 2024
6 of 7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the fix/bump-version branch February 24, 2024 00:48
@PSchmiedmayer
Copy link
Member

Shared that we encountered the issue here at ResearchKit/ResearchKit#1556 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants