Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct vertex checking typo in edge matching #15

Merged
merged 1 commit into from
May 25, 2024

Conversation

irtemed88
Copy link
Collaborator

While investigating #12, I noticed the meshing function was performing a comparison which seemed like it might be a typo. The other edge matching checks always check both vertices and it seemed like that should be the case here too.

Copy link
Collaborator

@aaptho aaptho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and can confirm this resolves some of the assertion failures we were seeing!

@aaptho aaptho merged commit 7515b0c into StandardCyborg:main May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants