Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_result method to st2client #6140

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

skiedude
Copy link

In order to check the results of a given execution, this endpoint is invaluable. The get_output method can sometimes return the information, but not always.

This method will be pulling information from the /api/v1/executions/{id}/result endpoint and returns a json response

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Feb 16, 2024
@CLAassistant
Copy link

CLAassistant commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

@guzzijones
Copy link
Contributor

please update the commit or sign the CLA for the Jacob Zufelt commit

@skiedude
Copy link
Author

skiedude commented Mar 7, 2024

@guzzijones sorry about that, fixed

@guzzijones
Copy link
Contributor

looks like the lint check failed.

@skiedude
Copy link
Author

Seems to be unrelated to my change

1. st2-auth-ldap 3.9.dev0 from git+https://github.com/StackStorm/st2-auth-ldap.git@master
    Expected sha256 hash of 29c6ff480b24e4bc316ed69eac5503c71f4700ed17649ae5c5ca8cd745e5852f when downloading st2-auth-ldap but hashed to 1b62240f8004316de753c3e2e20e629d0afb3337ea9a549f9022b4a7ba8c0499.

@skiedude
Copy link
Author

Same lint check is failing, not sure how my code change could have done this

1. st2-auth-ldap 3.9.dev0 from git+https://github.com/StackStorm/st2-auth-ldap.git@master
    Expected sha256 hash of 29c6ff480b24e4bc316ed69eac5503c71f4700ed17649ae5c5ca8cd745e5852f when downloading st2-auth-ldap but hashed to 1b62240f8004316de753c3e2e20e629d0afb3337ea9a549f9022b4a7ba8c0499.
    ```

@skiedude
Copy link
Author

@guzzijones is there more I need to do, in order to get a 2nd approver?

@skiedude
Copy link
Author

@cognifloyd can you do a 2nd review?

@skiedude
Copy link
Author

skiedude commented May 8, 2024

Is the milestone something I need to set? @cognifloyd

@guzzijones guzzijones added this to the 3.10.0 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants