New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_result method to st2client #6140
Open
skiedude
wants to merge
5
commits into
StackStorm:master
Choose a base branch
from
skiedude:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
PR that changes 10-29 lines. Very easy to review.
label
Feb 16, 2024
guzzijones
reviewed
Feb 23, 2024
please update the commit or sign the CLA for the Jacob Zufelt commit |
@guzzijones sorry about that, fixed |
looks like the lint check failed. |
Seems to be unrelated to my change
|
Same lint check is failing, not sure how my code change could have done this
|
guzzijones
approved these changes
Mar 15, 2024
@guzzijones is there more I need to do, in order to get a 2nd approver? |
@cognifloyd can you do a 2nd review? |
cognifloyd
approved these changes
Apr 28, 2024
Is the milestone something I need to set? @cognifloyd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to check the results of a given execution, this endpoint is invaluable. The
get_output
method can sometimes return the information, but not always.This method will be pulling information from the
/api/v1/executions/{id}/result
endpoint and returns a json response