-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: Trailing commas #2851
DOCS: Trailing commas #2851
Conversation
23fa3a1
to
190599b
Compare
190599b
to
6731ac6
Compare
I'm not sure people will understand the |
d2d60e6
to
5b73de5
Compare
yes! The "before vs. after" is much more readable. I'd add some narrative after the "after" to explain the benefit. Maybe something like: Suppose you want to add a new record after the "bar" line. In the "before" example, the diff would show the addition of the comma on the "bar" line plus the new record you added. In the "after" example the diff would be just the added record. This creates PRs that are easier to approve. (Feel free to reword that! It's just the first thing that came to my head.) |
617e4b8
to
934e536
Compare
934e536
to
4129e23
Compare
4129e23
to
fc34b67
Compare
Great! I've added two commits:
What do you think of this version? |
Hey that's great! Thanks! |
Fixes #2850.
Deeplink to the preview link:
https://docs.dnscontrol.org/~/revisions/b85k9WvN3UMndgrP20mT/advanced-features/code-tricks#trailing-commas