Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Trailing commas #2850

Closed
cafferata opened this issue Feb 24, 2024 · 3 comments · Fixed by #2851 or #2950
Closed

DOCS: Trailing commas #2850

cafferata opened this issue Feb 24, 2024 · 3 comments · Fixed by #2851 or #2950

Comments

@cafferata
Copy link
Collaborator

cafferata commented Feb 24, 2024

Another trick is to close your D() with END):

D("foo.com", ...
    A(...),
    A(...),
    A(...),
END)

END is just an alias for {}, which is ignored by DNSControl. However it makes a comma on the previous line required, like all other lines.

Cool! I didn't know this and it was always a small frustration. Maybe something to document as tips and tricks?

Originally posted by @cafferata in #2848 (comment)

@cafferata
Copy link
Collaborator Author

Additional question, when do we choose to provide the code examples with END and when not? Currently both are used.

@tlimoncelli
Copy link
Contributor

Excellent points!

I think it would serve the community best if we made END) the default. It isn't required, of course, but it just makes everything so much easier.

Here are the cleanups needed:

I'm working on get-zone. Would you be interested in the others?

@cafferata
Copy link
Collaborator Author

Would you be interested in the others?

Yes, certainly! This documentation advocate will work on it 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants