Highlight.js update + new theme classes #551
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Excited to dig into the new classes. I think this all looks super good, and TeX is improved out of the box already. |
|
Is this still being pursued? We (meaning the TeX.sx community) might have gone quiet about this but I don't think it's because we don't want our old color scheme back but rather out of resignation. If you are working on something and need feedback, I'm sure we'll be happy to assist. |
b-kelly
force-pushed
the
bkelly/hljs-update
branch
from
2a85582
to
aef96b9
Compare
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
b-kelly
force-pushed
the
bkelly/hljs-update
branch
from
aef96b9
to
2a85582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR exploring how we might take advantage of the new classes / syntax fixes that the most recent version of highlight.js has added.
Something I'd like to explore in this PR are some possible changes to the LaTeX theme. The tex community was not terribly happy with the new syntax highlighting/theme, so they took it upon themselves to contribute better highlighting detection upstream. I'd love to support these new classes so their hard work doesn't go to waste. They have a post here with suggestions on how to incorporate some of the changes into a new theme.
Changes
I've explicitly added highlight.js as a devDependency so we can tell what version our styles are being built against. I've also added a few of the unused classes to the
_stacks-code-blockwith a TODO comment on them, as well as a LaTeX code example to the docs.