Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump angular versions to 14 #264

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

dmkachko
Copy link

Refactor the project structure to comply recommendations

Refactor the project structure to comply recommendations
@Stabzs
Copy link
Owner

Stabzs commented Oct 11, 2022

Thank you for all of your fantastic work porting to version 14! Overall this looks good although there a few minor updates that are required. I'll pull this down today and test it.

@cmartost
Copy link

@Stabzs Have you been able to look at this?

@thomae82
Copy link

thomae82 commented Feb 2, 2023

Would be great if this would be released. We have a few projects > Angular 11 with "broken" dependencies.
By when will it be released?
What about Angular 15?

@Stabzs
Copy link
Owner

Stabzs commented Apr 13, 2023

@dmkachko are you able to review and complete the rest of the feedback?

@dmkachko
Copy link
Author

@Stabzs Sorry accidentally pushed the next update to the same branch.
I don't see too much feedback, though reverted the name of the project and urls accidentally changed.

@Stabzs
Copy link
Owner

Stabzs commented Apr 13, 2023

@dmkachko no problem! If you make a separate branch/pr, I can make sure both get pushed out this week. Are you able to speak to this comment/question? "Where did the css transpilation move to and how is it exposed in the built package?"

Thanks!

@dmkachko
Copy link
Author

dmkachko commented Apr 13, 2023

@Stabzs I am sorry, just in case I am missing something, for some reason I don't see any conversations or change requests attached to the PR, and don't have anything in the mail either. Where do you see this question?

@Stabzs Stabzs self-requested a review April 13, 2023 18:19
@Stabzs
Copy link
Owner

Stabzs commented Apr 13, 2023

EDIT: Found it...the request for changes didn't submit...my fault. Sorry about that!

@dmkachko odd, not sure why that is.

https://github.com/Stabzs/Angular2-Toaster/pull/264/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

Screen Shot 2023-04-13 at 12 20 27 PM

package.json Show resolved Hide resolved
projects/angular2-toaster/package.json Outdated Show resolved Hide resolved
projects/angular2-toaster/package.json Outdated Show resolved Hide resolved
projects/angular2-toaster/package.json Outdated Show resolved Hide resolved
projects/angular2-toaster/package.json Outdated Show resolved Hide resolved
@dmkachko
Copy link
Author

@Stabzs The feedback is implemented, pls let me know if you see anything else.

@dmkachko dmkachko requested a review from Stabzs April 27, 2023 14:02
@selangley-wa
Copy link

@Stabzs Merge this or #273 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants