2.1 #1656
Merged
2.1 #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +69,8 @@ public function __construct( | |||
| $startIndex, | |||
| $chunkSize, | |||
| callable $callback, | |||
| $shouldQueue = true | |||
| $shouldQueue = true, | |||
| $encoding = null | |||
There was a problem hiding this comment.
Can you update the docblock as well please
There was a problem hiding this comment.
Yes, of course. I have updated the docblock.
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Added option to pass encoding to Chunked CSV Reader.
Why Should This Be Added?
It improves the usability of the package.
Benefits
It will now support other file encodings, besides UTF-8.
Possible Drawbacks
None.
Verification Process
The parameter is optional, it doesn't affect the expected behavior of the ChunkedReadJob class.
Applicable Issues
#870
#1364