Allow all features to work in development #267
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as draft until #266, on which it depends, is merged. |
SteveMarshall
force-pushed
the
fully-working-devenv
branch
from
e691e0e
to
a1bcec2
Compare
Previously, we were building our Xapian database in our working directory which meant that, when we mount our working directory over the one in the container, we're left with no search index. To allow the search index to persist even with a mounted working directory, this moves the search index outside the working directory (using the new SEARCHDB_PATH environment variable). It also makes the search Make targets more explicit, and moves all the search connection creation into `backend.util` so that we can change everything at once in future.
In development, we mount our working directory over the one in the container, meaning that generated assets (like the stats graphs) aren't accessible. Rather than rebuild them into our working directory, this adds the version collected during the container build as a last-resort place to serve them from. We're only setting this in development mode to avoid having `collectstatic` (which we run in `live` mode) try to collect assets from its own target directory.
SteveMarshall
force-pushed
the
fully-working-devenv
branch
from
a1bcec2
to
28b940c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, getting search to work in development meant doing a bunch of bespoke work per environment. And our move to Docker-based development meant that we couldn't display stats graphs unless they were manually built with a mounted working directory after building the container.
This moves our search index out of the working directory and falls back to the pre-built, out-of-working-directory stats graphs, so that both now work as expected in development by default.