Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create default-security-group-rules.md #167

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

josephineSei
Copy link
Contributor

a guide for default security group rules

follow-up part of: SovereignCloudStack/standards#521

a guide for default security group rules

Signed-off-by: josephineSei <128813814+josephineSei@users.noreply.github.com>
josephineSei added a commit to SovereignCloudStack/standards that referenced this pull request Mar 20, 2024
remove example in favor of the guide in docs:
SovereignCloudStack/docs#167

Signed-off-by: josephineSei <128813814+josephineSei@users.noreply.github.com>
@berendt
Copy link
Member

berendt commented Apr 2, 2024

@markus-hentsch Can you please review this one?


### Example of a conform set of default Security Group Rules

This is an exapmle how a table with default Security Group Rules may look like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is an exapmle how a table with default Security Group Rules may look like:
This is an example how a table with default Security Group Rules may look like:


:::

The default security Group Rules can differ between default Security Groups and all other Security Groups - called `custom Security Group`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The default security Group Rules can differ between default Security Groups and all other Security Groups - called `custom Security Group`.
Default Security Group Rules may be adjusted individually for one of two different types of Security Groups:
1. The default Security Groups that are automatically created for projects initially.
2. Custom Security Groups created by users and initialized with a default rule set.
The default rule set is configured separately for each of those two types.

I found the original sentence a bit hard to grasp due to the meaning of "default" and "custom" being separate between rules and groups making this multi-dimensional but hard to convey in a single sentence. That's the reason I rephrased this to make a more clear distinction.

:::

The default security Group Rules can differ between default Security Groups and all other Security Groups - called `custom Security Group`.
So it is possible as an administrator to define rules only for one of those groups of Security Groups.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
So it is possible as an administrator to define rules only for one of those groups of Security Groups.
So it is possible as an administrator to define rules only for one of those types of Security Groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants