Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ use cluster stack content hash instead of git commit hash #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aniruddha2000
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #121

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>
@cluster-stack-bot cluster-stack-bot bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. area/code Changes made in the code directory labels May 10, 2024
@janiskemper janiskemper requested a review from jschoone May 13, 2024 09:26
@aniruddha2000
Copy link
Member Author

❯ ./bin/csctl create tests/cluster-stacks/docker/ferrol -m hash -o .test-releases
path "tests/cluster-stacks/docker/ferrol": cluster stack hash: "u2vqtxcihozkxc1ytku5qfwy0ao4foxzgwbgnracc"
Creating output in .test-releases/docker-ferrol-1-27-v0-sha-u2vqtxc
.tmp/cluster-addon/Chart.yaml updating version from v0 to v0-sha.u2vqtxc
.tmp/cluster-class/Chart.yaml updating version from v0 to v0-sha.u2vqtxc
No provider specific configuration in csctl.yaml. No need to call a plugin for provider "docker"
Created .test-releases/docker-ferrol-1-27-v0-sha-u2vqtxc

☸️  kind-cso 📁 csctl on  ani/issues/121 [$?] via  v1.21.6 
❯ ls .test-releases/docker-ferrol-1-27-v0-sha-u2vqtxc                            
cluster-addon-values.yaml  docker-ferrol-1-27-cluster-addon-v0-sha.u2vqtxc.tgz  docker-ferrol-1-27-cluster-class-v0-sha.u2vqtxc.tgz  hashes.json  metadata.yaml

test results

Copy link
Member

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jschoone can open further issues if he needs it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use cluster stack hash instead of git commit hash
2 participants