Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support new Cluster stack convention #104

Merged
merged 1 commit into from May 23, 2024
Merged

Conversation

aniruddha2000
Copy link
Member

New cluster stack has multi stage cluster addon which has clusteraddon.yaml in their release assets

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #103

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@cluster-stack-bot cluster-stack-bot bot added size/XL Denotes a PR that changes 800-2000 lines, ignoring generated files. area/code Changes made in the code directory labels Mar 20, 2024
@aniruddha2000 aniruddha2000 force-pushed the ani-syself/issues/103 branch 3 times, most recently from 5e425a5 to bb7e09e Compare May 22, 2024 12:48
@aniruddha2000
Copy link
Member Author

### the old cluster stack convention
☸️  kind-cso 📁 csctl on  ani-syself/issues/103 [$!] via  v1.21.6 
❯ ./bin/csctl create tests/cluster-stacks/docker/ferrol -m hash -o .test-releases
Creating output in .test-releases/docker-ferrol-1-27-v0-sha-bb7e09e
.tmp/cluster-addon/Chart.yaml updating version from v0 to v0-sha.bb7e09e
.tmp/cluster-class/Chart.yaml updating version from v0 to v0-sha.bb7e09e
path now: ".tmp/cluster-class"
path now: ".tmp/cluster-addon"
No provider specific configuration in csctl.yaml. No need to call a plugin for provider "docker"
Created .test-releases/docker-ferrol-1-27-v0-sha-bb7e09e

### the new cluster stack convention
☸️  kind-cso 📁 csctl on  ani-syself/issues/103 [$!?] via  v1.21.6 
❯ ./bin/csctl create tests/cluster-stacks/docker/valencia -m hash -o .test-releases 
Creating output in .test-releases/docker-valencia-1-27-v0-sha-bb7e09e
.tmp/cluster-class/Chart.yaml updating version from v0-sha.bb7e09e to v0-sha.bb7e09e
path now: ".tmp/cluster-class"
No provider specific configuration in csctl.yaml. No need to call a plugin for provider "docker"
Created .test-releases/docker-valencia-1-27-v0-sha-bb7e09e

New cluster stack has multi stage cluster addon which has
clusteraddon.yaml in their release assets

Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>
@janiskemper janiskemper merged commit 5d1b64a into main May 23, 2024
5 checks passed
@janiskemper janiskemper deleted the ani-syself/issues/103 branch May 23, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory size/XL Denotes a PR that changes 800-2000 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Multi-stage cluster addons
2 participants