New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Metal3 provider #82
Open
chess-knight
wants to merge
20
commits into
main
Choose a base branch
from
feat/metal3
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Also move image values to values.yaml and rename to k8s v1-29 Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Also switch back to v1-28 and fix node names Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Also update metrics-server addon Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
We have only one variable 'image' which can be used for both types of nodes Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Default values are based on test manifests Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Should prevent too many restarts Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Related to #77 Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
chess-knight
requested review from
mxmxchere,
jschoone,
paulphys and
michal-gubricky
May 20, 2024 14:28
jschoone
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #21
Special notes for your reviewer:
Test on virtualized environment:
See docs https://book.metal3.io/quick-start
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: