⚠️ Replace Helm binary with pure go packages based solution #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #33 Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
…nf()" Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
|
@NotTheEvilOne I am looking at your PR. I looked at the change and it looks good. I will test today. Sorry, for the delay. The main branch was updated and there are conflicts. Do you have time to solve them? Otherwise, I can work on that, too. |
guettli
reviewed
Jan 19, 2024
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
guettli
reviewed
Jan 22, 2024
guettli
requested changes
Jan 22, 2024
There was a problem hiding this comment.
@NotTheEvilOne please tell me how you want to proceed. You can rebase your PR on the current main branch, and inline helmTemplate(). Or I will do that. Please tell me what you prefer. Thank you.
NotTheEvilOne
force-pushed
the
prs/replace-helm-bin
branch
2 times, most recently
from
86ddf68
to
fbdc30d
Compare
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
NotTheEvilOne
force-pushed
the
prs/replace-helm-bin
branch
from
fbdc30d
to
c74db63
Compare
guettli
approved these changes
Jan 29, 2024
|
@NotTheEvilOne please merge the 4 commits into one commit. Then I can approve and merge it. Thank you. |
jschoone
added
the
Container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR replaces the Helm binary with a pure go packages based solution
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Closes: #33