You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would consider this function bad practice that needs replacement as soon as possible because of at least the following reasons:
Running an executable without any additional checks of unknown source even thought you think it's provided by the Dockerfile during the build process is an security issue
Downloading a binary for a single task seems bloated additionally
Each executable in a file system might be an unnecessary attack vector on containers.
KISS principle
There are at least two libraries (Helm [1] and go-helm-client [2]) that would just add the dependencies required to get the job done.
Reviewing the current operator I found
helmTemplate
which calls thehelm
executable to render the chart template.cluster-stack-operator/internal/controller/clusterstackrelease_controller.go
Line 312 in ad039ca
I would consider this function bad practice that needs replacement as soon as possible because of at least the following reasons:
There are at least two libraries (Helm [1] and go-helm-client [2]) that would just add the dependencies required to get the job done.
[1] https://github.com/helm/helm
[2] https://github.com/mittwald/go-helm-client
The text was updated successfully, but these errors were encountered: