Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Tilemap Viewer - Add 8x8 option to Edit Tiles menu and View in Memory for attribute value #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gzip
Copy link

@gzip gzip commented Mar 29, 2024

@SourMesen

The Edit Tiles context menu in Tilemap Viewer has been a very useful feature but occasionally a few more tiles would be helpful. I figured a jump to the next power of 2 should be plenty going forward.

Tilemap Viewer was also lacking a menu item to jump to the attribute value in memory. Before one had to take note of the attribute address, open Memory Viewer, select PPU Memory, and goto the address. A context menu is much more convenient. I patterned the text after the two add breakpoint items.

(Sorry about the whitespace changes, it's a setting in my editor and I didn't notice them until now since they're ignored in my command line diff.)

@gzip
Copy link
Author

gzip commented Mar 29, 2024

Might want to review with whitespace ignored.

@gzip gzip changed the title Tilemap Viewer - Add 8x8 option to Edit Tiles menu and View in Memory for attribute value Debugger: Tile Viewer - Add copy/paste tile memoryTilemap Viewer - Add 8x8 option to Edit Tiles menu and View in Memory for attribute value Mar 29, 2024
@gzip gzip changed the title Debugger: Tile Viewer - Add copy/paste tile memoryTilemap Viewer - Add 8x8 option to Edit Tiles menu and View in Memory for attribute value Debugger: Tilemap Viewer - Add 8x8 option to Edit Tiles menu and View in Memory for attribute value Mar 29, 2024
@gzip
Copy link
Author

gzip commented Mar 30, 2024

@SourMesen
These are features that I requested on the nesdev forums in January of last year so they might be on your todo list.

@SourMesen
Copy link
Owner

Thanks for the PRs!

I'm unfortunately going to be busy with RL stuff for the next 3 weeks, and likely won't have the time to look at these until around the end of April, sorry!

At first glance the code seems fine, so I should be able to merge these once I get back home.

@gzip
Copy link
Author

gzip commented Apr 2, 2024

Thanks for the heads up. Safe travels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants