-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unload problematic modules automatically (PulseAudio) & Improve Multi-Threading #268
Open
Curve
wants to merge
12
commits into
master
Choose a base branch
from
proposed-pulse-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will unload all problematic PulseAudio modules automatically and reload them when soundux exits
Curve
added
enhancement
New feature or request
backend
Something that needs to be changed in the backend
linux
Something that's specific to linux
labels
Jun 18, 2021
chore(deps): update lockpp, webviewpp refactor: UI now holds all playingSounds refactor: PlayingSound now provides methods to pause/resume/setVolume ... refactor: make PlayingSound manage mutexes instead of gAudio
Curve
changed the title
Unload problematic modules automatically (PulseAudio)
Unload problematic modules automatically (PulseAudio) & Improve Mutli-Threading
Jun 25, 2021
I just pushed another change that greatly improves Mutli-Threading, however it's not yet fully complete. The ProblemThe program would often dead-lock and the mutex-code was really messy. Proposed Solution
Further (required) improvements
|
D3SOX
changed the title
Unload problematic modules automatically (PulseAudio) & Improve Mutli-Threading
Unload problematic modules automatically (PulseAudio) & Improve Multi-Threading
Jun 27, 2021
Greatly reduces code size
refactor(hotkeys): shared_ptr -> unique_ptr, adjust to upcoming structural changes
…, fix typo, adjust to upcoming changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Something that needs to be changed in the backend
enhancement
New feature or request
linux
Something that's specific to linux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Currently we only detect if the
switch-on-connect
module is loaded and if so we prompt the user to unload it.However the module
role-cork
is also causing problems.Adding a detection for that modules would require us to show the user yet another prompt.
This may impact users differently:
Proposed Solution
Our proposed solution is to automatically unload those modules from soundux and reload them once soundux exits.
That way the user is not required to click through dozens of prompts to use the application and continue to make use of the problematic modules after soundux exits.
Possible Improvements