Skip to content
This repository has been archived by the owner on Dec 17, 2018. It is now read-only.

Offline sync via NSPersistentHistory, support for CloudKit Sharing #51

Open
wants to merge 216 commits into
base: master
Choose a base branch
from
Open

Offline sync via NSPersistentHistory, support for CloudKit Sharing #51

wants to merge 216 commits into from

Conversation

deeje
Copy link
Collaborator

@deeje deeje commented Dec 4, 2018 •
edited

I really liked your project, and have spent some time adding to it.

  • refactored names to standardize on "push" and "pull" to help me better understand the flow of data
  • refactored isPublic to support pushing to private, public, or both databases
  • incorporated support for relationships via Oleg Müller
  • added support for NSPersistentHistoryTracking, to enable offline sync
  • added support for CloudKit Sharing via the sharedDatabase
  • updated unit tests
  • updated the example app

I still need to update the following

  • online tests
  • documentation
  • pass Travis CI
    but wanted to get this PR up to gather thoughts. Lemme know.

deeje and others added 30 commits May 17, 2018 16:06
normalize on Push & Pull nomenclature
5eef747
ignore .DS_Store files
47f0d09
more nomenclature changes
53c2f62
still more nomenclature changes
c36d4bd
don’t need to use self.
75a1b3e
enable persistent history in Core Data
4142fc3
move the push code outside of the didSave handler
ae8fdb2
@deeje
update to Swift 4.2
51913b2
@Scytalion @deeje
supporting transformable attributes
2c7ce03
@Scytalion @deeje
adding fixes for fixing relationships
c908d21 
# Conflicts:
#	Source/Classes/Pull/SubOperations/RecordToCoreDataOperation.swift
@Scytalion @deeje
error handling
c3a7dab
@deeje
update CloudCore to Swift 4.2
1dcee9e
@deeje
support for push to CloudKit via PersistentHistory
7738059
@deeje
CloudCore.usePersistenHistoryForPush
a7bd3b6
@deeje
fix delete
30d73c9
@deeje
processPersistentHistory when reachability changes
f71a5a1
@deeje
catch overall CKModify record operation errors
1636053
@deeje
delete CK records from tombstone recordData
ac0ada3
@deeje
don’t push all if using persistent history
f644ce8 
and clean up private MOCs
@deeje
rename to PullResult for consistency
000a82d
@deeje
more normalizing on push/pull terminology
98ef980
@deeje
TODO: optimize by using change.updatedProperties
f01a249
@deeje
actually delete history as we push
eb25281
@deeje
use recordNames to match CK and CD objects
3bfa66a
@deeje
add ServiceAttributeNames.contains(…)
4110154
@deeje
use existing recordName if it exists
1eca3df
@deeje
support for public push
0cc7f5a
@deeje
replace .isPublic with ServiceAttributeNames.scopes
5231870 
allow Core Data schema to define which scopes to push
@deeje
only setRecordInfo for scopes
5175bd1
@deeje
use container.databse(with: scope)
b75027e
deeje added 30 commits May 10, 2022 09:56
@deeje
(fix a typo in ReadMe)
de85998
@deeje
(more ReadMe edits for clarity)
a24f877
@deeje
(updated authors attributions)
cc5ec9e
@deeje
(update comparison w NSPersistentCloudKitCOntainer)
6f2e983
@deeje
implement CacheState.unload
ca363ff
@deeje
update example to call removeLocal()
6b49b57
@deeje
Merge pull request #28 from deeje/feature/Cacheable
5d31ad3 
Feature/Cacheable
@deeje
fix compiler errors in Example app
3be6fdf
@deeje
Merge pull request #31 from deeje/fix/example5.0
0c1b64b 
Update Example app
@deeje
update version to 5.0.2
764379e
@deeje
Merge pull request #32 from deeje/fix/versionInSpec
8d609c4 
5.0.2 - Update Version in Podspec
@deeje
progress only increases, qos is configurable
a1d4281
@deeje
bump podspec version to 5.1.0
5cb19d1
@deeje
always use persistentHistory, reduce churn on rapid saves
a83107a 
remove old code paths
@deeje
need to update removeStatus locally to stay in sync
32ed3f9
@deeje
simplify the .upload triggering
5ab9a31
@deeje
increase delay in sync to 5 sec after last save
3e56f14
@deeje
cacheable ops can already be in running
d1e0855
@deeje
restart all long-lived ops if one errors out
15c5173
@deeje
if CKErrorRetryAfterKey, wait to push more changes
cacc122
@deeje
centralize the pause timer
2ab656e
@deeje
share MOC across CoreDataObserver & CacheManager
950234b 
for processing the push of history and upload of cacheables
@deeje
push operations are atomic
4b93c61
@deeje
rapid inserts could cause converter to fail
997898d 
why use yet another background context?!
@deeje
(remove testing code)
d0b3cec
@deeje
more cleanup of ObjectToRecordOperation
899df48
@deeje
background tasks are only on iOS
85098a4
@deeje
update ReadMe to include links to MediaBook app
258b7b0
@deeje
NSPersistentHistoryTracking is now required
fb9b5e4
@deeje
Merge pull request #33 from deeje/feature/5.1
17a0b8d 
5.1 - improved sync and upload
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sorix Sorix Awaiting requested review from Sorix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deeje @Sorix @Scytalion @hyerra