{Custom Format:Format} Rename Token
#6585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alanoll
commented
Mar 2, 2024
markus101
requested changes
Mar 3, 2024
There was a problem hiding this comment.
Please add some tests to verify the behaviour (and prevent breaking changes in the future) in a new fixture in https://github.com/Sonarr/Sonarr/tree/develop/src/NzbDrone.Core.Test/OrganizerTests/FileNameBuilderTests
|
I added Unit Tests for both Something I ran into was that Custom Formats allow for spaces in their Names. Multiple Trash Guide formats have them (example). I tweaked the Did some quick tests in an expression tester: All existing FileNameBuilder tests passed after the change as well. |
markus101
requested changes
Mar 8, 2024
Co-authored-by: Mark McDowall <markus.mcd5@gmail.com>
markus101
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing the
{Custom Format:Format}rename token to allow position of Custom Formats when renaming.This re-implements #4453 for Custom Formats, and would satisfy Radarr/Radarr#6801 if it gets cherry-picked to over there.
It is a smaller change because it's really just allowing exact placement of the Format Name instead of the old Preferred Words implementation that replaced with the matched values.
Database Migration
NO
Issues Fixed or Closed by this PR