Fix - Extend maven proxy settings usage to https #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this pull request?
While I was reading the code of this project to find an elegant way to pass proxy settings to this maven plugin, I was pleasantly surprised to discover this plugin can read maven configuration to bind proxy settings. The test factory converts maven proxy configuration to java system properties but forgets these properties must be also set for https configurations. The goal of this pull request is to fix this, completing the missing implementation.
What does this code do?
This code keeps the current proxy detection and just adds the same settings for https. I don't make any distinction with https because maven proxy config uses one active proxy for all kind of requests, where java system properties makes a distinction between them.
Pull request requirements: