Fix Virtual DHCP Server: Correct IP reassignment #1994
+22
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
DHCP_NAK does not work correctlly
Changes make it work correctlly
Description of changes:
①If IP address in user's note is changed, then reply to DHCP REQUEST with DHCP NAK.
This makes DHCP sequence begin with DHCP DISCOVER.
②If there is any entry with the same MAC address, then remove it.
Unused lease time record is deleted from IP lease table.
③Reassigning static IP address is partially modified.
④Thease changes enable to switch between static and dynamic IP address assignment.
Users do not need to restart the VPN server.
Example below:
Already set to IPv4:192.168.30.222 in user's note.
First, set to IPv4:192.168.30.234 in user's note. Indicated with yellow line.
Second, delete IPv4:192.168.30.234 from user's note. Indicated with yellow line.
Third, set to IPv4:192.168.30.222 in user's note. Indicated with yellow line.
User can switch the way of IP address assignment at any time.
Attach A:
Lease Limit:40 seconds
DisableSessionReconnect: true
Time-out Period: 20 seconds