New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed comments and missing argument name in strtable file #1907
base: master
Are you sure you want to change the base?
Conversation
src/bin/hamcore/strtable_ru.stb
Outdated
@@ -4833,7 +4833,7 @@ CMD_SyslogGet_COLUMN_2 syslog Server Host Name | |||
CMD_SyslogGet_COLUMN_3 syslog Server Port Number | |||
|
|||
|
|||
# ConnectionList command | |||
# ConnectionGet command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be ConnectionList because ConnectionList command is just below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your opinion. I swapped comments for ConnectionList
command and ConnectionGet
command in strtable_ru.stb file.
@@ -4851,7 +4851,7 @@ CMD_HubList_Args ListaHub | |||
# Hub command | |||
CMD_Hub Select Virtual Hub to Manage | |||
CMD_Hub_Help Use this to select the Virtual Hub to be the target of administration. For an administration utility with the status of being connected to a VPN Server, before executing a command to set or manage a Virtual Hub, you must use the Hub command to select the Virtual Hub to manage. \nWhen in the status of being connected to a VPN Server in Virtual Hub Admin Mode, you can select a single Virtual Hub to be the target of administration but you cannot select other Virtual Hubs. When having the status of being connected to the VPN Server in Server Admin Mode, you can make all Virtual Hubs the target of administration. \nTo get a list of Virtual Hubs that currently exist on the VPN Server, use the HubList command. \nFor the VPN Bridge, you can only select the Virtual Hub that has the name "BRIDGE". | |||
CMD_Hub_Args Hub [nome] | |||
CMD_Hub_Args Hub [name] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name is nome in Portuguese.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but I think it is fine to change this to name(English) because other *_Args has [name]
.
src/bin/hamcore/strtable_ru.stb
Outdated
@@ -7122,7 +7122,7 @@ CMD_TrafficClient_ERROR_HOSTPORT The host name or port number is incorrectly spe | |||
# TrafficServer command | |||
CMD_TrafficServer Запустить средство тестирования скорости сетевого трафика в режиме сервера | |||
CMD_TrafficServer_Help Используется для запуска инструмента измерения пропускной способности в режиме сервера. \nДве команды, TrafficClient и TrafficServer, используются для измерения пропускной способности между двумя компьютерами, соединенными сетью IP. \nУкажите номер порта и запустите серверную часть с помощью команды TrafficServer, чтобы прослушивать подключение от TrafficClient другого компьютера. \nВы можете отобразить более подробную информацию об инструменте измерения пропускной способности, введя "TrafficClient ?". \n\nПримечание. Эту команду можно вызвать из утилиты управления командной строкой SoftEther VPN. Вы также можете выполнить эту команду при подключении к текущему VPN-серверу или VPN клиенту в режиме администрирования, но фактически осуществляет связь и измеряет пропускную способность тот компьютер, на котором выполняется команда, а не компьютер с которого выполнено подключение в режиме администрирования. | |||
CMD_TrafficServer_Args TrafficServer [порт] [/NOHUP:да|нет] | |||
CMD_TrafficServer_Args TrafficServer [port] [/NOHUP:да|нет] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be either of the following.
CMD_TrafficServer_Args TrafficServer [порт] [/NOHUP:да|нет]
CMD_TrafficServer_Args TrafficServer [port] [/NOHUP:yes|no]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
port in russian is indeed порт
, although I'm not sure about the need to localize the actual cmd line params (aka /NOHUP:yes|no
should be the correct ones I think)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced it with CMD_TrafficServer_Args TrafficServer [port] [/NOHUP:yes|no]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since NOHUP parameter is determined by whether it is a string starting with "y", it should be written as "yes" in the legend.
SoftEtherVPN/src/Cedar/Console.c
Line 1443 in 18dc262
bool GetParamYes(LIST *o, char *name) |
… command in strtable_ru.stb file
Changes proposed in this pull request: