Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate GitHub workflow for online building of SCInsta IPA #28

Closed
wants to merge 0 commits into from

Conversation

zeuikli
Copy link

@zeuikli zeuikli commented Apr 18, 2024

Example : https://github.com/zeuikli/BHInsta/actions/runs/8732321318

Run workflow :
CleanShot 2024-04-18 at 12 10 19@2x

Please enter the iOS SDK version and the IPA URL, then wait for the completion of the IPA build.

Build Status : CleanShot 2024-04-18 at 12 23 38@2x

Confirm that the IPA file can be installed via eSign, but note that the image download feature is still not functioning properly.

@SoCuul SoCuul added enhancement New feature or improvement status: planned This is planned for a future release labels Apr 19, 2024
@SoCuul SoCuul self-assigned this Apr 19, 2024
@SoCuul SoCuul linked an issue Apr 19, 2024 that may be closed by this pull request
Copy link
Owner

@SoCuul SoCuul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just needs a few changes before it can be merged.

.github/workflows/delete-workflow-runs.yml Outdated Show resolved Hide resolved
.github/workflows/buildapp.yml Outdated Show resolved Hide resolved
.github/workflows/buildapp.yml Outdated Show resolved Hide resolved
.github/workflows/buildapp.yml Outdated Show resolved Hide resolved
.github/workflows/buildapp.yml Outdated Show resolved Hide resolved
.github/workflows/buildapp.yml Outdated Show resolved Hide resolved
@zeuikli
Copy link
Author

zeuikli commented Apr 20, 2024

After the review, you can merge your commit into the main branch.

@SoCuul SoCuul changed the title Activate GitHub workflow for online building of BHInsta IPA Activate GitHub workflow for online building of SCInsta IPA Apr 20, 2024
@SoCuul SoCuul self-requested a review April 20, 2024 07:05
Copy link
Owner

@SoCuul SoCuul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to look good. Before I merge it though, could you test out the workflow with the commits I've added to the PR.

If everything works as intended, I'll merge it as soon as I can!

@SoCuul SoCuul added this to the v0.4.0 milestone Apr 20, 2024
@zeuikli
Copy link
Author

zeuikli commented Apr 20, 2024

Update build.sh to fix the issue of IPA file not being found.

Added script commands to install pyzule.
#Install pyzule
bash -c "$(curl https://raw.githubusercontent.com/asdfzxcvbn/pyzule/main/install-pyzule.sh)"

Modified the build.sh script by replacing certain instructions originally designated for BHInsta with those intended for SCInsta.

You can review my latest PR to verify these changes.

@SoCuul
Copy link
Owner

SoCuul commented Apr 20, 2024

Update build.sh to fix the issue of IPA file not being found.

Added script commands to install pyzule. #Install pyzule bash -c "$(curl https://raw.githubusercontent.com/asdfzxcvbn/pyzule/main/install-pyzule.sh)"

Modified the build.sh script by replacing certain instructions originally designated for BHInsta with those intended for SCInsta.

You can review my latest PR to verify these changes.

It's super inefficient to install pyzule each time someone tries to build it, as they only need to install it once.

Could you just add it as another step in the buildapp workflow?

Also the build.sh functionality should be independant of the workflow. The workflow calls it from the repo folder, so it should work fine as-is.

@SoCuul SoCuul self-requested a review April 20, 2024 08:58
Copy link
Owner

@SoCuul SoCuul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that needs to be changed is moving the pyzule stuff to a build step and reverting the changes in build.sh. The script should run fine if in the workflow step it cds into the folder, as all the paths in the shell script are relative to the current directory.

build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
@zeuikli
Copy link
Author

zeuikli commented Apr 22, 2024

Initially, you can proceed with the merge, but it's imperative to ensure that the "pyzule" tool is installed using GitHub Actions to facilitate the building of the IPA.

@SoCuul
Copy link
Owner

SoCuul commented Apr 22, 2024

Initially, you can proceed with the merge, but it's imperative to ensure that the "pyzule" tool is installed using GitHub Actions to facilitate the building of the IPA.

I do not feel comfortable merging this into the main branch in its current state, as it would cause confusion for users who do not understand why the workflow fails on their end.

@SoCuul SoCuul removed this from the v0.4.0 milestone May 4, 2024
@zeuikli zeuikli closed this May 13, 2024
@SoCuul
Copy link
Owner

SoCuul commented May 13, 2024

@zeuikli If you're working on this, what do you think about adding a dropdown in the workflow settings to select between sideloaded ipa, rootless and rootful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement status: planned This is planned for a future release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Integrate with GitHub Actions
2 participants