Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set max-width to 100% and height to auto #260

Merged
merged 1 commit into from May 22, 2024

Conversation

sdumetz
Copy link
Contributor

@sdumetz sdumetz commented Mar 7, 2024

max-width was already set in styles.scss#L83, but not in editor leading to inconsistent behaviour.

Moreover, max-width without height: auto leads to stretched images.

I created a new css file because the current content.ui.min.cssand content.min.css seems directly imported from tinyMCE and keeping them pristine will probably help future updates.

With those changes it is still possible to manually force images to stretch by specifying a different height in the image block popup.

@gjcope
Copy link
Collaborator

gjcope commented Mar 7, 2024

We've been working on a fix as well since there are several inconsistencies like this. But this seems reasonable. Thanks!

@gjcope gjcope merged commit edb428a into Smithsonian:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants