Dpo3 dpkrt 754 #548

natashaJ-NZP · 2023-07-03T16:03:31Z

On SubjectListItem.tsx, I added an extra table column and inserted the collection ID prop to populate the values for each Subject List Item (line 69-72).

…identifier fix: numerical identifiers converted to strings

- ingestData.ts commented out old code and placed new validation code beneath. - EdanCollection.ts added a new function called checkEdanIdentifier - Just added comments various functions across other files outside of ingestData.ts and EdanCollection.ts

* Validation check for identifiers - ingestData.ts commented out old code and placed new validation code beneath. - EdanCollection.ts added a new function called checkEdanIdentifier - Just added comments various functions across other files outside of ingestData.ts and EdanCollection.ts * Resolving pull request 'flags' from Eric M.'s code review

…d added directions on the Upload page only. WIP: will be fixing the blue color to only apply on the upload page.

…oad page. (WIP) adding tooltips to each field component in the Ingestion process; however, d/t the complexity of the application, I will require extensive tracing and logic building to incorporate the Tooltip component inside each field component. Will require more time than expected.

* (wip) Validation check for identifiers - ingestData.ts commented out old code and placed new validation code beneath. - EdanCollection.ts added a new function called checkEdanIdentifier - Just added comments various functions across other files outside of ingestData.ts and EdanCollection.ts * Resolving pull request 'flags' from Eric M.'s code review * Changed the background color of the ingest/discard buttons to blue and added directions on the Upload page only. WIP: will be fixing the blue color to only apply on the upload page. * test commit - to see if the changes applied update in real time. * Added file format text to the bottom of the upload section on the upload page. (WIP) adding tooltips to each field component in the Ingestion process; however, d/t the complexity of the application, I will require extensive tracing and logic building to incorporate the Tooltip component inside each field component. Will require more time than expected.

…ckrat into DPO3DPKRT-747

…etails.tsx and UnitDetails.tsx

jahjedtieson · 2023-07-03T20:41:28Z

server/graphql/schema/ingestion/resolvers/mutations/ingestData.ts

+            if  (!edanId)
+                return { success: false, error: `Invalid EDAN Record ID: ${identifier.identifier}}` };
+
+            if (regexEdan.test(edanId))


I'm noticing the newly added ICollection.checkEdanIdentifier(). Why isn't that being used here, instead of regexEdan?

jahjedtieson · 2023-07-03T20:42:55Z

server/graphql/schema/unit/resolvers/queries/searchIngestionSubjects.ts

@@ -14,6 +15,9 @@ export default async function searchIngestionSubjects(_: Parent, args: QuerySear

    const results: DBAPI.SubjectUnitIdentifier[] = [];
    const resultSet: Set<string> = new Set<string>();
+    console.log(`db: ${JSON.stringify(resultsDB)}`);


While previously involved in the project, my suggestion was to not leave console logging in our committed code. For server-side logging, use the logger. For client-side logging, comment out console statements before committing. Perhaps guidance has changed here, but I would still strongly suggest using server logging instead of console.log.

jahjedtieson

Please address linting error. Perhaps consider using yarn lint before submitting code to ensure that all lint errors are identified.

EMaslowskiQ and others added 15 commits April 11, 2023 10:53

fix: numerical identifiers converted to strings

dcfadf0

Merge pull request #538 from Smithsonian/DPO3DPKRT-731/fix-numerical-…

fd30a5f

…identifier fix: numerical identifiers converted to strings

Resolving pull request 'flags' from Eric M.'s code review

f1eafc0

Changed the background color of the ingest/discard buttons to blue an…

3255372

…d added directions on the Upload page only. WIP: will be fixing the blue color to only apply on the upload page.

test commit - to see if the changes applied update in real time.

34612eb

Changes to add tooltips to all the Field boxes in Ingestion

79a72a5

Merge branch 'DPO3DPKRT-747' of https://github.com/Smithsonian/dpo-pa…

e064d26

…ckrat into DPO3DPKRT-747

Created a LabelTooltipText component. Added the component to SubjectD…

b53da73

…etails.tsx and UnitDetails.tsx

Adding the rest of the tooltips to the details page

8b82f94

Added a warning message for process upload

ba82303

Finished adding the Idenitifier Collection ID to the Subject List

02a01d2

natashaJ-NZP requested a review from EMaslowskiQ July 3, 2023 16:03

jahjedtieson reviewed Jul 3, 2023

View reviewed changes

natashaJ-NZP added 2 commits July 6, 2023 08:33

Resolved ES Lint errors

b6f7152

Resolved two more trailing space errors from ES Lint

4e2a1ff

EMaslowskiQ force-pushed the develop branch 2 times, most recently from cac0d06 to b05e532 Compare January 24, 2024 22:01

EMaslowskiQ force-pushed the develop branch from 6563288 to 178c52e Compare February 1, 2024 03:51

EMaslowskiQ force-pushed the develop branch 2 times, most recently from 008e5d6 to aa7535c Compare May 13, 2024 15:01

EMaslowskiQ closed this May 17, 2024

EMaslowskiQ deleted the DPO3DPKRT-754 branch May 17, 2024 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dpo3 dpkrt 754 #548

Dpo3 dpkrt 754 #548

natashaJ-NZP commented Jul 3, 2023

jahjedtieson Jul 3, 2023

jahjedtieson Jul 3, 2023

jahjedtieson left a comment

Dpo3 dpkrt 754 #548

Dpo3 dpkrt 754 #548

Conversation

natashaJ-NZP commented Jul 3, 2023

jahjedtieson Jul 3, 2023

Choose a reason for hiding this comment

jahjedtieson Jul 3, 2023

Choose a reason for hiding this comment

jahjedtieson left a comment

Choose a reason for hiding this comment