Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Gridster with CSS flex grids #128

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

YtvwlD
Copy link
Contributor

@YtvwlD YtvwlD commented Mar 31, 2019

This is an attempt to upstream the changes I did to chaosdorf/dashpi in 2017. I don't know whether this can or should be merged but I figured it might be useful. (The commits should probably be squashed.)

What it does: Replaces Gridster with a few lines of CSS.

New features: widgets scale when the window size changes
Lost features: drag&drop, widgets more than two columns wide, widgets more than one row high

This requires adjustments to the dashboards, but affects just the sample project.

@kinow kinow added this to the 1.2 milestone May 16, 2020
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good plan. I've been using CSS flex grids with Vue and Vuetify, and it works well, and has good compatibility with browsers.

@YtvwlD could you rebase your branch and resolve conflicts? Then if that works similarly to Gridster we can merge it and release with 1.2.

@YtvwlD
Copy link
Contributor Author

YtvwlD commented May 17, 2020

I have rebased this onto current master.

@kinow
Copy link
Member

kinow commented May 18, 2020

Thanks a lot for fixing it so quickly @YtvwlD !

I've just finished the retroactive changelog: https://github.com/Smashing/smashing/blob/master/CHANGELOG.md

There are quite a few changes not released yet. I will cut 1.2.0 as-is first, and leave it in RubyGems for a while (1 month or more I guess?) to see if there's any issue reported.

And in the meantime will review this one, check why Travis failed, and hopefully merge and prepare 1.3.0 with it.

Thanks!
Bruno

@kinow
Copy link
Member

kinow commented Jun 3, 2020

@YtvwlD I've just rebased the PR, and added an extra commit that should fix the build on Travis.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good PoC, but cannot be merged yet.

I think we just need to work on other options for drag n' drop. The multiple columns/rows could be achieved too I think, with just CSS (I think).

At the moment I get a scrollbar on Ffox and Chromium. Maybe because of the legend in one of the graphs. And some extra space in the widget with buzzwords.

image

@kinow kinow marked this pull request as draft June 3, 2020 23:02
@kinow
Copy link
Member

kinow commented Jun 3, 2020

Build failed only on 2.2.7, wihch is not a biggie now, as we can work around the other issues before worrying about this one.

@kinow kinow modified the milestones: 1.3.0, 1.3.1 Jun 4, 2020
@kinow
Copy link
Member

kinow commented Jun 29, 2020

Posted on Gitter today, an alternative to Grister: https://github.com/hootsuite/grid

@rompic
Copy link
Contributor

rompic commented Jul 1, 2020

there is also https://github.com/gridstack/gridstack.js

@kinow kinow mentioned this pull request Jul 23, 2020
@kinow kinow modified the milestones: 1.3.1, 1.3.2 Jan 30, 2021
@kinow kinow modified the milestones: 1.3.2, 1.3.3 Feb 26, 2021
@kinow kinow modified the milestones: 1.3.3, 1.4.0 Mar 6, 2021
@kinow
Copy link
Member

kinow commented May 4, 2021

Rebased, and removed the <center> tag. I think that's the element that was causing the x-scrollbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants