Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rules): update rules model objects to match current API #156

Merged
merged 1 commit into from May 19, 2022
Merged

fix(rules): update rules model objects to match current API #156

merged 1 commit into from May 19, 2022

Conversation

rossiam
Copy link
Contributor

@rossiam rossiam commented May 18, 2022

BREAKING CHANGE: Updated rules model objects have been significantly updated.

  • updated rules model objects to match current API
  • renamed some very generically named objects
  • more idiomatic TypeScript "enums"

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document
  • My code follows the code style of this project (npm run lint produces no warnings/errors)
  • Any required documentation has been added
  • I have added tests to cover my changes

john-u
john-u suggested changes May 19, 2022
View reviewed changes
src/endpoint/rules.ts Outdated Show resolved Hide resolved
src/endpoint/rules.ts Outdated Show resolved Hide resolved
@rossiam rossiam requested a review from john-u May 19, 2022 16:14
@rossiam
fix(rules): update rules model objects to match current API
cf45821 
BREAKING CHANGE: Updated rules model objects have been significantly updated.
@rossiam rossiam merged commit 28b04ec into SmartThingsCommunity:master May 19, 2022
@rossiam rossiam deleted the rules-updates branch May 19, 2022 17:28
@smartthingspi
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rossiam rossiam mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-u john-u john-u approved these changes

@bflorian bflorian Awaiting requested review from bflorian

@Sitlintac Sitlintac Awaiting requested review from Sitlintac

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rossiam @smartthingspi @john-u