Improve i18n support #1162
Open
Improve i18n support #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcfr Is this relevant. It has been outstanding for more than 1 year. |
|
Yes, let's keep it open. |
|
Can it be merged? |
jcfr
force-pushed
the
improve-i18n-support
branch
from
286e5e4
to
3e1ea33
Compare
|
@carlos-luque I re-based the topic we worked on during one of the project week. Is it something you could test ? |
This commit adds CMake function "SlicerFunctionAddPythonScriptTrFilesTargets" used to ensure input expected by lupdate/lrelease translation tools are generated. The CMake function associates custom commands with each python scripts and also adds a convenience target called "Add<TargetName>PythonScriptTrFiles" to explicitly regenerate the .py.tr files. The custom commands generate the .py.tr files by invoking a python cli (CMake/Rewrite.py) replacing calls to "slicer.util.tr" with "QT_TRANSLATE_NOOP". The python cli "CMake/Rewrite.py" internally uses the astor python package. Updates SlicerConfig to set Slicer_BUILD_I18N_SUPPORT, Slicer_UPDATE_TRANSLATION and Slicer_LANGUAGES. Co-authored-by: Carlos Luque <carlos.luque@ulpgc.es>
Removes the dependency of library to *.qm files and instead add the target GenerateSlicerTranslationQMFiles allowing to explicitly re-generate the '*.qm" files..
This commit adds GenerateSlicerTranslationTemplates target allowing to generate "<BaseName>_untranslated.ts" files. To facilitate their distribution, the files are generated in the directory "<CMAKE_BINARY_DIR>/TranslationTemplates".
After talking with "Carlos Luque <carlos.luque@ulpgc.es>", we decided to keep the file simpler. This could be revisited later. Co-authored-by: Carlos Luque <carlos.luque@ulpgc.es>
jcfr
force-pushed
the
improve-i18n-support
branch
from
3e1ea33
to
71e06d4
Compare
lassoan
reviewed
Mar 5, 2020
| import astor | ||
|
|
||
|
|
||
| class RewriteTr(ast.NodeTransformer): |
There was a problem hiding this comment.
What does this function (and the whole file) do?
| @@ -94,12 +96,12 @@ def setup(self): | |||
| inputFiducialsNodeSelector.addEnabled = False | |||
| inputFiducialsNodeSelector.removeEnabled = False | |||
| inputFiducialsNodeSelector.connect('currentNodeChanged(bool)', self.enableOrDisableCreateButton) | |||
| pathFormLayout.addRow("Input Fiducials:", inputFiducialsNodeSelector) | |||
| pathFormLayout.addRow(tr("EndoscopyWidget", "Input Fiducials:"), inputFiducialsNodeSelector) | |||
There was a problem hiding this comment.
tr() arguments are in not in this order (see https://doc.qt.io/qt-5/qobject.html#tr).
It should be tr("Input Fiducials:", "EndoscopyWidget").
| self.parent.connect('mrmlSceneChanged(vtkMRMLScene*)', | ||
| inputFiducialsNodeSelector, 'setMRMLScene(vtkMRMLScene*)') | ||
|
|
||
| # CreatePath button | ||
| createPathButton = qt.QPushButton("Create path") | ||
| createPathButton = qt.QPushButton(tr("EndoscopyWidget", "Create path")) |
There was a problem hiding this comment.
Instead of hardcoding "EndoscopyWidget" everywhere, could we add a mixin to the class, which would add the class name automatically? It would simplify the syntax to tr("Create path").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slicer.i18n.tr())<ModuleName>_untranslated.tsfilesGenerateSlicerTranslationTemplatesandGenerateSlicerTranslationQMFilesSee https://github.com/NA-MIC/ProjectWeek/blob/master/PW31_2019_Boston/Projects/Globalization3DSlicer_OHIF/README.md#progress-and-next-steps