-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SlicerTractParcellation extension #2037
base: main
Are you sure you want to change the base?
Conversation
@zhangfanmark thanks for putting this together. Please do go through the checklist in this template and perform the steps. It may seem like a lot but they should be quick for either you or Kening to do. Things like including some screenshots and descriptive text to form a tutorial will really help anyone who wants to use your tutorial. Also adding the |
Hi @pieper Kening is working on the checklist and he will do a pull request later. Thank you!!! |
Thanks Fan 👍 If Kening has any questions at all, let us know. |
@pieper We have accomplished the extension, https://github.com/SlicerDMRI/SlicerTractParcellation, here is the link. Please let me know if there are any imperfections. And do we need to create a new pull request to refresh the version? |
Hi Kening - The license is good and the image looks nice so thanks for the update. What we were looking for is the items on the checklist at the top of this page, e.g. going through point by point and ensuring that the listed items have been taken into account. For example, the first unchecked box is "Extension description summarizes in 1-2 sentences what the extension is usable (should be understandable for non-experts)". While there is a sentence in the README, I'm not sure it's appropriate yet, since very few people would know what WMA or ORG are. Here it would be nicer to spell out the terms "White Matter Analysis" and "O'Donnell Research Group" and include links to places where they can get more information. Another point is that the URLs in the CMakeLists file haven't been updates. For example, this line still has the placeholder You can have a look at other extensions to see how they have addressed the checklist items. Here's a recent example that is nicely done: SlicerMONAIAuto3DSeg. It has a nice description and several images that give a clear idea what the extension does. It also has valid URLs and other content. You don't need a new pull request, just update your site and edit the checklist above as you confirm that each of the topics has been addressed. I hope it's clear why we ask developers to follow this template so that users can discover and understand your contributions. Best, |
Also update category from "Libraries" to "Diffusion"
b2396cf
to
1d11e97
Compare
New extension
3d-slicer-extension
GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extension
in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topicsSettings
and in repository settings uncheckWiki
,Projects
, andDiscussions
(if they are currently not used)About
in the top-right corner of the repository main page and uncheckReleases
andPackages
(if they are currently not used)