Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce lapdMouseBrowser extension #2036

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

makphd
Copy link

@makphd makphd commented Apr 17, 2024

New extension

  • Extension has a reasonable name (not too general, not too narrow, suggests what the extension is for)
  • Repository name is Slicer+ExtensionName
  • Repository is associated with 3d-slicer-extension GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter 3d-slicer-extension in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topics
  • Extension description summarizes in 1-2 sentences what the extension is usable (should be understandable for non-experts)
  • Any known related patents must be mentioned in the extension description.
  • LICENSE.txt is present in the repository root. MIT (https://choosealicense.com/licenses/mit/) or Apache (https://choosealicense.com/licenses/apache-2.0/) license is recommended. If source code license is more restrictive for users than MIT, BSD, Apache, or 3D Slicer license then the name of the used license must be mentioned in the extension description.
  • Extension URL and revision (scmurl, scmrevision) is correct, consider using a branch name (main, release, ...) instead of a specific git hash to avoid re-submitting pull request whenever the extension is updated
  • Extension icon URL is correct (do not use the icon's webpage but the raw data download URL that you get from the download button - it should look something like this: https://raw.githubusercontent.com/user/repo/main/SomeIcon.png)
  • Screenshot URLs (screenshoturls) are correct, contains at least one
  • Homepage URL points to valid webpage containing the following:
    • Extension name
    • Short description: 1-2 sentences, which summarizes what the extension is usable for
    • At least one nice, informative image, that illustrates what the extension can do. It may be a screenshot.
    • Description of contained modules: at one sentence for each module
    • Tutorial: step-by-step description of at least the most typical use case, include a few screenshots, provide download links to sample input data set
    • Publication: link to publication and/or to PubMed reference (if available)
    • License: We suggest you use a permissive license that includes patent and contribution clauses. This will help protect developers and ensure the code remains freely available. We suggest you use the Slicer License or the Apache 2.0. Always mention in your README file the license you have chosen. If you choose a different license, explain why to the extension maintainers. Depending on the license we may not be able to host your work. Read here to learn more about licenses.
    • Content of submitted s4ext file is consistent with the top-level CMakeLists.txt file in the repository (description, URLs, dependencies, etc. are the same)
  • Hide unused features in the repository to reduce noise/irrelevant information:
    • Click Settings and in repository settings uncheck Wiki, Projects, and Discussions (if they are currently not used)
    • Click the settings icon next to About in the top-right corner of the repository main page and uncheck Releases and Packages (if they are currently not used)

@makphd makphd closed this Apr 17, 2024
@makphd makphd reopened this Apr 17, 2024
@lassoan
Copy link
Contributor

lassoan commented Apr 17, 2024

Thank you, very nice! It is great to see that the extension has been updated!

A few comments:

  • On my Windows computer, all downloads fail with error 404:

Downloading m01\m01_Lobes.nrrd
The server couldn't fulfill the request.
Error code: 404
[ERROR] time: 00:00

  • "Show browser" button should raise the browser window to the top (minor usability issue)
  • Documentation: 3D Slicer however, loads raster images assuming an LPS coordinate system and models assuming an RAS coordinate system - this is no longer the case. If a model does not contain coordinate system information then Slicer now assumes that it is in LPS.

@lassoan lassoan added the Status: Awaiting Response ⏳ Waiting for a response/more information label Apr 17, 2024
@jamesobutler
Copy link
Contributor

@lassoan The s4ext in the archive directory should also be removed if this extension is being added back in? https://github.com/Slicer/ExtensionsIndex/blob/0a2ade7e30c84884c751f24f2f0b5579845c2a47/ARCHIVE/lapdMouseBrowser.s4ext

lapdMouseBrowser was originally archived in 638a2ea.

@lassoan
Copy link
Contributor

lassoan commented Apr 17, 2024

Yes, we'll do it in the same commit and then git will recognize it as a file move, as the file content is almost the same.

@jcfr jcfr changed the title Add files via upload Reintroduce lapdMouseBrowser extension May 1, 2024
@makphd
Copy link
Author

makphd commented May 14, 2024

@lassoan

Thanks for the comments. I've updated the code to work in Windows. I deleted the reference to Slicer's coordinate systems from the README. As for the browser window, I've tried many different combinations of activate and raise and haven't been able to make it show on top of the main Slicer window. If you have any pointers for me, I'd be happy to give it another go.

Melissa

Thank you, very nice! It is great to see that the extension has been updated!

A few comments:

  • On my Windows computer, all downloads fail with error 404:

Downloading m01\m01_Lobes.nrrd
The server couldn't fulfill the request.
Error code: 404
[ERROR] time: 00:00

  • "Show browser" button should raise the browser window to the top (minor usability issue)
  • Documentation: 3D Slicer however, loads raster images assuming an LPS coordinate system and models assuming an RAS coordinate system - this is no longer the case. If a model does not contain coordinate system information then Slicer now assumes that it is in LPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Response ⏳ Waiting for a response/more information
Development

Successfully merging this pull request may close these issues.

None yet

4 participants