fixed out of range indexing for angle_compensate #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We encoutered issues on A3 with angle_compensate active in Sensitivity mode (and other non 360 array sizes). Basically the indexing goes out of range, causing some random crashes on Raspberry Pi for instance, especially when LIDAR has all points valid (non 0). It worked fine on x86 architectures, but still goes out of range and may cause some random bugs.
The patch simply skips points that are out of the array. I tried to make sense of the angle_compensate calculations, but I'm not sure what it's exactly supposed to do, also it seems pretty inefficient, overwriting the same array cells multiple times.