Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOOM-1280][BpkDatePicker] Remove useless styling #3388

Merged
merged 2 commits into from Apr 29, 2024
Merged

[LOOM-1280][BpkDatePicker] Remove useless styling #3388

merged 2 commits into from Apr 29, 2024

Conversation

metalix2
Copy link
Contributor

@metalix2 metalix2 commented Apr 25, 2024

Reviewed the Styling applied to the BpkDatePicker and found it made no effect to the Calendar component. Tested across chrome, firefox and safari on varying mobile widths. Looked up the history of the changes and couldn't find much to indicate the reason it was added.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • Type declaration (.d.ts) files updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@metalix2 metalix2 added the patch Patch production bug label Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against a8895d5

Copy link

Visit https://backpack.github.io/storybook-prs/3388 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3388 to see this build running in a browser.

Copy link
Contributor

@mungodewar mungodewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metalix2 metalix2 merged commit b6afd26 into main Apr 29, 2024
9 checks passed
@metalix2 metalix2 deleted the LOOM-1280 branch April 29, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants