Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor bpk-component-loading-button styles #3276

Closed
wants to merge 2 commits into from

Conversation

mungodewar
Copy link
Contributor

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • Type declaration (.d.ts) files updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@mungodewar mungodewar changed the title add refactor bpk-component-loading-button styles refactor bpk-component-loading-button styles Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against a1b60e0

Copy link

Visit https://backpack.github.io/storybook-prs/3276 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3276 to see this build running in a browser.

iconOnly &&
(large
? 'bpk-loading-button__icon--large-icon-only'
: 'bpk-loading-button__icon--icon-only'),
(link || linkOnDark) && 'bpk-loading-button__icon--link',
);

return (
// $FlowFixMe[cannot-spread-inexact] - inexact rest. See 'decisions/flowfixme.md'.
<BpkButton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also possibly use this as an opportunity to migrate this component to Buttonv2?

@mungodewar mungodewar closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants