Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-8034]: add bpk-price v2 for experiment #3272

Closed
wants to merge 1 commit into from

Conversation

LuoTuxiu
Copy link
Contributor

@LuoTuxiu LuoTuxiu commented Mar 7, 2024

Figma: link

image

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • Type declaration (.d.ts) files updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@LuoTuxiu LuoTuxiu changed the title feat: add bpk v2 for experiment [BD-8034]: add bpk v2 for experiment Mar 7, 2024
@LuoTuxiu LuoTuxiu changed the title [BD-8034]: add bpk v2 for experiment [BD-8034]: add bpk-price v2 for experiment Mar 7, 2024
@LuoTuxiu LuoTuxiu added the minor Non breaking change label Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 4888225

Copy link

github-actions bot commented Mar 7, 2024

Visit https://backpack.github.io/storybook-prs/3272 to see this build running in a browser.

Copy link
Member

@olliecurtis olliecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ensure the PR title includes

[JIRA Number][Component updated] as per the first item in the checklist

@olliecurtis
Copy link
Member

Hey @LuoTuxiu is this PR still needed and ready to go?

@LuoTuxiu
Copy link
Contributor Author

LuoTuxiu commented May 7, 2024

This pr is not ready. Just close it.

@LuoTuxiu LuoTuxiu closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants