Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DTO-5100] BpkChipGroup #3198

Open
wants to merge 89 commits into
base: main
Choose a base branch
from
Open

[DTO-5100] BpkChipGroup #3198

wants to merge 89 commits into from

Commits on Sep 21, 2023

  1. wip

    Iain Cattermole committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    74516e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Merge branch 'main' of github.com:Skyscanner/backpack into DTO-4223

    Iain Cattermole committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    47c712a View commit details
    Browse the repository at this point in the history

  2. Create nudger for desktop

    Iain Cattermole committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    17d03c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Refactor chip groups to better match api

    Iain Cattermole committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    92ec095 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. More examples, support for dismissable chips, tests

    Iain Cattermole committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    40480ef View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. More WIP, Update docs, add tests, add a11y roles, add TODOs

    Iain Cattermole committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    50ffcb4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into DTO-4223

    @Iain530
    Iain530 committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b5690b3 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Fix shadow clipping bug, remove scroll indicators

    Iain Cattermole committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2ba1a5a View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Update prop names

    Iain Cattermole committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    6e24bf2 View commit details
    Browse the repository at this point in the history

  2. increase rail padding to 4px for focus indicator

    Iain Cattermole committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    73207a3 View commit details
    Browse the repository at this point in the history

  3. Nudger tests, fix single select prop

    Iain Cattermole committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    f9c1d78 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. clean up imports

    Iain Cattermole committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    9273120 View commit details
    Browse the repository at this point in the history

  2. Add tests for stateful chip groups

    Iain Cattermole committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    56a1e8b View commit details
    Browse the repository at this point in the history

  3. Add sticky chip to a11y tests

    Iain Cattermole committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e92b9a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Start readme

    Iain Cattermole committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    fe8ef2d View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge branch 'main' of github.com:Skyscanner/backpack into DTO-4223

    Iain Cattermole committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6327d6d View commit details
    Browse the repository at this point in the history

  2. Use BpkIconChip, @import -> @use

    Iain Cattermole committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    c89f975 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Fix nudgers jumpiness

    Iain Cattermole committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3b347f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. update todo comment

    Iain Cattermole committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    9c90bd8 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Fix some type errors, write README

    Iain Cattermole committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    63063f7 View commit details
    Browse the repository at this point in the history

  2. a11y improvements

    Iain Cattermole committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    dcdbc32 View commit details
    Browse the repository at this point in the history

  3. generate type declaration files

    Iain Cattermole committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    adea076 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into DTO-4223

    @Iain530
    Iain530 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9f2fefb View commit details
    Browse the repository at this point in the history

  5. build css

    Iain Cattermole committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b3452ff View commit details
    Browse the repository at this point in the history

  6. remove custom classname support

    Iain Cattermole committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e3d05f1 View commit details
    Browse the repository at this point in the history

  7. remove classname from nudger

    Iain Cattermole committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    708d7ef View commit details
    Browse the repository at this point in the history

  8. fix untyped imports

    Iain Cattermole committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    6b4a662 View commit details
    Browse the repository at this point in the history

  9. update tests with a11y improvements

    Iain Cattermole committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9c13146 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. add nudger labels

    Iain Cattermole committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    38e1791 View commit details
    Browse the repository at this point in the history

  2. add nudger labels to tests, snaps, type declarations

    Iain Cattermole committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    80db707 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into DTO-4223

    @Iain530
    Iain530 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    79d0f47 View commit details
    Browse the repository at this point in the history

  4. add missing license heading

    Iain Cattermole committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8d7ea52 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. ChipGroup - Add support for visual label inc. examples (#3369) 

    * Add support for visual label inc. examples

* Add padding for label

* Fix css casing
    @steviehailey-skyscanner
    steviehailey-skyscanner committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e5c6cae View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Update docs link 

    Co-authored-by: Ollie Curtis <8831547+olliecurtis@users.noreply.github.com>
    @Iain530 @olliecurtis
    Iain530 and olliecurtis committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    894a0a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Split definitions for group types (#3370) 

    * Split definitions for group types

* Split sub-component definitions to reduce conditional logic

* PR comment action and TS fix

---------

Co-authored-by: Iain Cattermole <22656572+Iain530@users.noreply.github.com>
    @steviehailey-skyscanner @Iain530
    steviehailey-skyscanner and Iain530 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    58f20e2 View commit details
    Browse the repository at this point in the history

  2. remove generated css files

    Iain Cattermole committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f49912b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:Skyscanner/backpack into DTO-4223

    Iain Cattermole committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a34bf81 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. remove scroll indicator overrides

    Iain Cattermole committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1896bb6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:Skyscanner/backpack into DTO-4223

    Iain Cattermole committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8cc0244 View commit details
    Browse the repository at this point in the history

  3. refactor ChipGroup tests

    Iain Cattermole committed May 1, 2024
    Configuration menu
    Copy the full SHA
    81a0f4e View commit details
    Browse the repository at this point in the history

  4. refactor SingleSelectChipGroup tests

    Iain Cattermole committed May 1, 2024
    Configuration menu
    Copy the full SHA
    48d5cb0 View commit details
    Browse the repository at this point in the history

  5. refactor Nudger tests

    Iain Cattermole committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c1b9601 View commit details
    Browse the repository at this point in the history

  6. fix type errors

    Iain Cattermole committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3f3095e View commit details
    Browse the repository at this point in the history

  7. remove snapshot

    Iain Cattermole committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1a814f0 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. remove compiled css

    Iain Cattermole committed May 2, 2024
    Configuration menu
    Copy the full SHA
    56bfd19 View commit details
    Browse the repository at this point in the history

  2. ChipGroup - Remove label padding (#3407) 

    * Remove label padding

* Make nudger labels required
    @steviehailey-skyscanner
    steviehailey-skyscanner committed May 2, 2024
    Configuration menu
    Copy the full SHA
    834dfcc View commit details
    Browse the repository at this point in the history

  3. Set nudger labels as required in typedef (#3411)

    @steviehailey-skyscanner
    steviehailey-skyscanner committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5693e07 View commit details
    Browse the repository at this point in the history

  4. fix export style

    Iain Cattermole committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e6d5157 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into DTO-4223

    @Iain530
    Iain530 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    822bdab View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'main' of github.com:Skyscanner/backpack into DTO-4223

    Iain Cattermole committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1c60641 View commit details
    Browse the repository at this point in the history

  2. remove type declaration files

    Iain Cattermole committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4595b17 View commit details
    Browse the repository at this point in the history

  3. Rename chip groups

    Iain Cattermole committed May 23, 2024
    Configuration menu
    Copy the full SHA
    315042e View commit details
    Browse the repository at this point in the history

  4. Rename chip groups

    Iain Cattermole committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ea201b0 View commit details
    Browse the repository at this point in the history

  5. fix zoom test

    Iain Cattermole committed May 23, 2024
    Configuration menu
    Copy the full SHA
    63f1092 View commit details
    Browse the repository at this point in the history

  6. remove default nudger labels

    Iain Cattermole committed May 23, 2024
    Configuration menu
    Copy the full SHA
    ab550bf View commit details
    Browse the repository at this point in the history

  7. refactor nudger positions

    Iain Cattermole committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2f0d314 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. remove InternalProps classname

    Iain Cattermole committed May 24, 2024
    Configuration menu
    Copy the full SHA
    812451a View commit details
    Browse the repository at this point in the history

  2. refactoring

    Iain Cattermole committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3410878 View commit details
    Browse the repository at this point in the history

  3. styling/refactoring

    Iain Cattermole committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1b072ce View commit details
    Browse the repository at this point in the history

  4. Move stateful ChipGroups to storybook only

    Iain Cattermole committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f8729ea View commit details
    Browse the repository at this point in the history

  5. fix type errors

    Iain Cattermole committed May 24, 2024
    Configuration menu
    Copy the full SHA
    50785cb View commit details
    Browse the repository at this point in the history

  6. fix list keys

    Iain Cattermole committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2664de9 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge branch 'main' into DTO-4223

    @Iain530
    Iain530 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9affa37 View commit details
    Browse the repository at this point in the history

  2. debug nudger test

    Iain Cattermole committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0bec6e2 View commit details
    Browse the repository at this point in the history

  3. sync act

    Iain Cattermole committed May 28, 2024
    Configuration menu
    Copy the full SHA
    366ff34 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. use waitFor

    Iain Cattermole committed May 31, 2024
    Configuration menu
    Copy the full SHA
    1bc4373 View commit details
    Browse the repository at this point in the history

  2. no waiting

    Iain Cattermole committed May 31, 2024
    Configuration menu
    Copy the full SHA
    983840f View commit details
    Browse the repository at this point in the history

  3. act only

    Iain Cattermole committed May 31, 2024
    Configuration menu
    Copy the full SHA
    15528f0 View commit details
    Browse the repository at this point in the history

  4. no fake timers

    Iain Cattermole committed May 31, 2024
    Configuration menu
    Copy the full SHA
    625a588 View commit details
    Browse the repository at this point in the history

  5. debug act

    Iain Cattermole committed May 31, 2024
    Configuration menu
    Copy the full SHA
    dc23d8d View commit details
    Browse the repository at this point in the history

  6. no async

    Iain Cattermole committed May 31, 2024
    Configuration menu
    Copy the full SHA
    cdefa6b View commit details
    Browse the repository at this point in the history

  7. render in act

    Iain Cattermole committed May 31, 2024
    Configuration menu
    Copy the full SHA
    ec6a519 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Increase rail padding for focus indicators

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9817f8e View commit details
    Browse the repository at this point in the history

  2. clear timers

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8782ed7 View commit details
    Browse the repository at this point in the history

  3. dont clear timers

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a1365bc View commit details
    Browse the repository at this point in the history

  4. advanceTimers userEvent

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ffafa99 View commit details
    Browse the repository at this point in the history

  5. update mock values

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c3f9a29 View commit details
    Browse the repository at this point in the history

  6. no mock values

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a5baac3 View commit details
    Browse the repository at this point in the history

  7. tweak mock values

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5ef8753 View commit details
    Browse the repository at this point in the history

  8. debug

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    46703b2 View commit details
    Browse the repository at this point in the history

  9. debug

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    bc96802 View commit details
    Browse the repository at this point in the history

  10. use waitFor again

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9dbba83 View commit details
    Browse the repository at this point in the history

  11. less specific attribute testing

    Iain Cattermole committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9db1c3a View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. padding for focus indicators at the end

    Iain Cattermole committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    24a63d2 View commit details
    Browse the repository at this point in the history

  2. negative margins for focus indicators

    Iain Cattermole committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4d09246 View commit details
    Browse the repository at this point in the history

  3. only render nudgers when visible

    Iain Cattermole committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    14fd3fe View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into DTO-4223

    @Iain530
    Iain530 committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    be46132 View commit details
    Browse the repository at this point in the history

  5. Use bpk tokens for 4px 

    Co-authored-by: Ollie Curtis <8831547+olliecurtis@users.noreply.github.com>
    @Iain530 @olliecurtis
    Iain530 and olliecurtis committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    8ea37d8 View commit details
    Browse the repository at this point in the history

  6. use bpk tokens for nudger

    Iain Cattermole committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    9ffdff8 View commit details
    Browse the repository at this point in the history