No longer request cookies if the user has refused #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Romitou
force-pushed
the
feature/negative-cookie
branch
from
4602522
to
ec32950
Compare
Romitou
force-pushed
the
feature/negative-cookie
branch
from
ec32950
to
a98115e
Compare
AyhamAl-Ali
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds cookie refusal storage, so that the banner is not displayed all the time when cookies are refused. In accordance with a comment posted in issue #52, this practice is authorised, this cookie also being a non-personalised cookie for the user.
Originally posted by @BaeFell in #52 (comment)