Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hanging signs to the sign category #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheLimeGlass
Copy link
Contributor

any oak sign should reflect any sign regardless of it's placement, as long as it's an oak sign, it will fall under the oak sign category.

Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it just adds the changes that were rejected in #88

@Fusezion

This comment was marked as off-topic.

@TheLimeGlass
Copy link
Contributor Author

Damn that's crazy SkriptLang/Skript#6220

@sovdeeth
Copy link
Member

sovdeeth commented Dec 6, 2023

The issue with this is that "oak sign" shouldn't include hanging oak signs, in my opinion. "Any oak sign" should, though, for comparison.
It'd be pretty simple to split the two up.

@Moderocky
Copy link
Member

Damn that's crazy SkriptLang/Skript#6220

Your PR does not address this issue at all.
The issue you have linked is about warped and crimson (the pink and blue nether wood types) hanging signs not being included in the signs alias, and cherry and bamboo regular signs not being included in the alias.
This PR doesn't add either of these missing things to the alias, it adds the hanging signs to the regular signs alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants