Fix EffHealth - slot durability not accounting correctly #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure to add tests to check for regression |
sovdeeth
added
bug
sovdeeth
approved these changes
May 5, 2024
Moderocky
approved these changes
May 5, 2024
Moderocky
added
the
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix my mistake in #6586 where I forgot to update slot durability accordingly.
Do we believe this pr should also include the 1.20.5/6 changes to durability? Based off my testing earlier this morning they are pretty bugged and adding support for at least being functional isn't out of the scope entirely.
It's possible I didn't test this correctly as the related issue is very hard for me to read with how much random junk is included in it.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6643