Fix entity casting issue and add regression test. #6614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moderocky
added
bug
sovdeeth
approved these changes
Apr 26, 2024
cheeezburga
added a commit
to cheeezburga/Skript
that referenced
this pull request
Apr 28, 2024
- Split the properties and behaviour into their own syntax so the patterns weren't weird to accommodate for that - Changed LivingEntity to Entity to prevent ClassCastException being thrown (see issue SkriptLang#6612 and PR SkriptLang#6614)
APickledWalrus
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the entity bug thingy.
I also cleaned up the supertype-finder method so it's a little more useful in these situations.
I don't think any other Entity-returning classes make the same mistake, but there might be syntax returning other types that also gets it wrong.
Target Minecraft Versions: any
Requirements: none
Related Issues: fixes 6612