Effect Command API Enhancement & Skript Event Support #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Moderocky
reviewed
Apr 24, 2024
Moderocky
approved these changes
Apr 30, 2024
| else | ||
| sender.sendMessage(ChatColor.RED + "Error in: " + ChatColor.GRAY + SkriptColor.replaceColorChar(command)); | ||
| log.printErrors(sender, "(No specific information is available)"); | ||
| sender.sendMessage(ChatColor.RED + "Your effect command '" + SkriptColor.replaceColorChar(command) + "' was cancelled."); |
There was a problem hiding this comment.
These error messages probably ought to be lang entries, but it's okay if you feel that's out of scope for this PR.
There was a problem hiding this comment.
Seeking for extended support of this in the skriptlang channel.
src/main/java/ch/njol/skript/conditions/CondEffectCommandIsValid.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondEffectCommandIsValid.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides enhancements on how Effect Commands are handled, and adds Skript event support for users to listen to.
API Change: EffectCommandEvent
Currently, this event is only called whenever the parsed effect is valid. With this PR, the event is now called whenever an effect command attempt is done. The said event class now has a nullable
Effectfield to determine whether the parsed effect is valid. Due to this change,EffectCommandEvent#setCommand(String)has been removed due to unavailable better alternative to retain this method whilst returning the parsed effect.Skript Event Support
With this PR, users are able to listen to EffectCommandEvent.
Event values:
Syntaxes:
[the] effect [command] is [not:(not |in)]valid-- checks whether the parsed effect command in EffectCommandEvent is validTarget Minecraft Versions: any
Requirements: none
Related Issues: none