Add tests for vector syntaxes #6163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
enhancement
|
Looking good so far, I'm ticking off all the ones you make so that nobody else makes the same. |
Moderocky
added
the
adds-missing-test
|
As far as I can see, the remaining ones are:
then
and
|
APickledWalrus
approved these changes
Dec 18, 2023
src/main/java/ch/njol/skript/expressions/ExprVectorCylindrical.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprVectorSpherical.java
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprVectorAngleBetween.sk
Outdated
Show resolved
Hide resolved
src/test/skript/tests/syntaxes/expressions/ExprVectorArithmetic.sk
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
sovdeeth
added
2.9
Moderocky
added
the
patch-ready
sovdeeth
added a commit
to sovdeeth/Skript
that referenced
this pull request
Apr 18, 2024
* vector tests pt1 * Add test for vector random being within expected bounds. * Add XYZ vector test. * Add vector XYZ component test. * Add vector length test. * Add vector normalise test. * Add vector from yaw and pitch test. * Add vector of location test * Add squared length test. * Add location vector offset test. * Add missing indefinite article to syntax. * Add tests for spherical vectors. * Fix a little oopsie. * Apply suggestions from code review Co-authored-by: Patrick Miller <apickledwalrus@gmail.com> * test updates --------- Co-authored-by: Moderocky <admin@moderocky.com> Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for all vector-related syntaxes. Fixes up some docs/pattern issues with assorted vector syntaxes as well.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6158