Configuration for custom events #5724
Open
+191
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 07e1700)
11 tasks
andriemc
approved these changes
Aug 19, 2023
sovdeeth
requested changes
Aug 19, 2023
There was a problem hiding this comment.
Cool pr!
I am a little worried about users adding async events and then having issues using syntax inside those events (like the chat event in 2.7 betas), but I suppose it's on their heads if they add an async event. Perhaps a warning about that in the file would be good.
edit: Apparently i forgot to save this comment:
You can leave the name blank, which doesn't seem to cause issues but should not be allowed imo:
sovdeeth
requested changes
Aug 21, 2023
sovdeeth
approved these changes
Aug 21, 2023
Moderocky
requested changes
Sep 8, 2023
Moderocky
force-pushed
the
master
branch
3 times, most recently
from
bd134d0
to
3f08853
Compare
Moderocky
approved these changes
May 3, 2024
Moderocky
added
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a configuration for registering simple events, ported from Skellett.
Target Minecraft Versions: any
Requirements: none
Related Issues: #121 (non-closing)