Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to test manage blocked numbers #680

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FunkyMuse
Copy link

No description provided.

@FunkyMuse FunkyMuse marked this pull request as draft August 31, 2023 09:03
@tibbi
Copy link
Member

tibbi commented Aug 31, 2023

  1. top bars are too light after long pressing an item
  2. add spaces at selected item counter at the top left corner, should be "1 / 2" instead of "1/2"
  3. clicking on the selected item counter should trigger Select all, then Deselect all
  4. text size of menu items Copy number to clipboard and Delete are too small
  5. long pressing the top menu buttons both in casual menu and contextual should vibrate and show a label of the menu button
  6. selected items in light mode and ripple cannot be seen at all
  7. with light mode the top status bar isnt visible at all, top icons, clock, battery etc should use dark colors
  8. checkbox and 3 dots colors dont change properley

@tibbi
Copy link
Member

tibbi commented Aug 31, 2023

  1. clicking on 3 dots, the floating ones on the right side should have circle ripple, not square

@FunkyMuse
Copy link
Author

managed to fix everything except: long pressing the top menu buttons both in casual menu and contextual should vibrate and show a label of the menu button

I think Compose doesn't bring this out of the box, will look for a flexible solution

@tibbi
Copy link
Member

tibbi commented Sep 5, 2023

  1. in dark Material You theme, the top bars are still way too light, cant we use something like on the main app screen?
  2. with Material You theme the marked selected item should be a bit colored, not just grey
  3. in Light theme after long pressing an item the top bars should be dark, not primary color. And no matter what colors are the top bars, the top system bar and our menu should use the same colors, either light or dark.
  4. when selection mode is active, pressing Back should just deselect everything, not close the screen
  5. floating menu text sizes are ok, but lets add a bit more vertical spacing
  6. 3 dots and inactive checkboxes should use the text color
  7. sometimes after I long press an item and lift by finger up, it gets deselected
  8. long pressing a menu item should vibrate and show the label under the button with bigger letters, not above it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants