Add redirect from Medium to Scribe #311
Conversation
There was a problem hiding this comment.
I couldn't wait for this PR to be merged, so I checked out your code, ran a build, and loaded it locally in Firefox (desktop version 93 on macOS 11.6). I noticed that the extension was broken. After some debugging I found some errors and missing parts. Some I left as review comments, others are:
- Missing section for manually input new Scribe instances in
src/pages/options/options.html - Toggle for disabling Scribe in popup (
src/pages/popup/)
I think I can push my code with fixes on top of this PR, or you can fix it. Since you're the owner of the PR it is up to you. Let me know!
Awesome work on this and I hope we can get this merged soon! 😄
|
Thanks for the fixes. I also notices several problems, which I don't know the solution to (yet):
So, I will convert this PR to draft until these issues are fixed. |
|
What is the status here? |
|
I'm currently distracted by some other projects. I'll get back to this when I have time. |
|
OK this should work now. There are some occasional glitch in UI that didn't happen before for some reason I don't know and can't reproduce. |
|
Gentle ping @SimonBrazell Is there something else I should change? |
|
Thanks. I will do that this or next weekend if possible.
…On Tue, 2 Nov 2021, 19:49 Brian van Burken, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/_locales/en/messages.json
<#311 (comment)>
:
> @@ -143,9 +151,9 @@
"message": "Use FreeTube over Invidious when possible",
"description": "Label for 'Use FreeTube over Invidious when possible' option (options)."
},
- "nitterRandomPool": {
I think you accidentally replace the Nitter random pool with the Scribe
one.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#311 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AETHFHSJBO5CBOPDU4YOUZDUJ7M6FANCNFSM5FXG3BFQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
do you know when will it be merged with the main branch of the original addon? |
|
Thanks @Huy-Ngo I'll check this out now. |
Multiple Medium domains would be redirected to two known Scribe instances: scribe.rip scribe.nixnet.services
- Change scribe's default input to 'Random instance (none selected)' - Add random pool variables and functions for scribe
Bibliogram randomization would be removed if that removal were merged.
Also fix Wikipedia's typo
This fixes random pool dropdown brokeness
Wrap lines to avoid similar conflicts later
|
Fixed the conflict and added another instance. |
README.md
Outdated
| @@ -47,6 +57,9 @@ Privacy Redirect allows setting custom instances, instances can be found here: | |||
| - [Mojeek](https://www.mojeek.com) | |||
| - [Presearch](https://www.presearch.org) | |||
| - [Whoogle](https://benbusby.com/projects/whoogle-search/) | |||
| - [Scribe](https://sr.ht/~edwardloveall/scribe/) instances:, an alternative frontend for Medium: | |||
| - [scribe.rip](https://scribe.rip/) | |||
| - [NixNet scribe](scribe.nixnet.services/) | |||
There was a problem hiding this comment.
Should the https://scribe.citizen4.eu instance be in this list as well?
|
Hopefully next update this will be merged? |
|
I miss this feature so much |
|
I've switched over to this maintained fork: https://libredirect.github.io/ |
Multiple Medium domains would be redirected to two known Scribe instances:
https://scribe.rip
https://scribe.nixnet.services
This resolves #310