feat: ✨ Add disableAutoScroll to Showcase #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sahil-Simform
requested changes
Mar 8, 2024
| @@ -244,6 +244,7 @@ class Showcase extends StatefulWidget { | |||
| /// will still provide a callback. | |||
| final VoidCallback? onBarrierClick; | |||
|
|
|||
| final bool disableAutoScroll; | |||
There was a problem hiding this comment.
Can you please add documentation for this variable?
There was a problem hiding this comment.
Can you please rename this to the same variable used in ShowCaseWidget as they serve the same purpose? i.e. enableAutoScroll
| @@ -325,6 +327,7 @@ class Showcase extends StatefulWidget { | |||
| this.disableDefaultTargetGestures = false, | |||
| this.tooltipPosition, | |||
| this.onBarrierClick, | |||
| this.disableAutoScroll = false | |||
There was a problem hiding this comment.
Please make default value true as if parent class(ShowCaseViewWidget) variable enableAutoScroll is true than we don't need to add enableAutoScroll in all child class(ShowCase)
| @@ -386,7 +389,7 @@ class _ShowcaseState extends State<Showcase> { | |||
| }); | |||
|
|
|||
| if (activeStep == widget.key) { | |||
| if (showCaseWidgetState.enableAutoScroll) { | |||
| if (showCaseWidgetState.enableAutoScroll && !this.widget.disableAutoScroll) { | |||
There was a problem hiding this comment.
I believe you can directly use widget and remove this here.
|
Hi @Sensirex, thank you for your contribution. Can you please resolve conflicts and PR comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add disabling auto scroll (disableAutoScroll) for concrete tooltip (Showcase)
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues